Skip to content

regression: EmojiPicker not displaying scrollbar properly #35536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Mar 17, 2025
Merged

regression: EmojiPicker not displaying scrollbar properly #35536

kodiakhq merged 3 commits into from
Mar 17, 2025

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 17, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Introduced here: #33796

When replacing rc-scrollbars we've created a separated implementation for virtualized lists but we didn't replaced in the EmojiPicker

Issue(s)

CORE-1056

Steps to test or reproduce

  • open a room
  • open the emoji picker
  • scrollbar should be visible

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 17, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cabe2f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.5.0 milestone Mar 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35536/

Built to branch gh-pages at 2025-03-17 21:37 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (79a6c1f) to head (cabe2f4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35536   +/-   ##
========================================
  Coverage    59.66%   59.66%           
========================================
  Files         2826     2826           
  Lines        68369    68369           
  Branches     15148    15148           
========================================
  Hits         40793    40793           
  Misses       24962    24962           
  Partials      2614     2614
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the reg/emojiPicker-scrollbar branch from 4024af2 to 7d187c8 Compare March 17, 2025 17:58
@dougfabris dougfabris marked this pull request as ready for review March 17, 2025 20:28
@dougfabris dougfabris requested a review from a team as a code owner March 17, 2025 20:28
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Mar 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 17, 2025
@kodiakhq kodiakhq bot merged commit 30e3fcb into develop Mar 17, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the reg/emojiPicker-scrollbar branch March 17, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dougfabris @gabriellsh